From 735ffa1ad5ae3e4f5fa774029b01da16df05db28 Mon Sep 17 00:00:00 2001 From: Dan Bornstein Date: Tue, 21 Mar 2023 12:13:09 -0700 Subject: [PATCH] Note the Node bugs. --- src/network-protocol/private/Http2Wrangler.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/network-protocol/private/Http2Wrangler.js b/src/network-protocol/private/Http2Wrangler.js index 139634594..ea5a2a7ec 100644 --- a/src/network-protocol/private/Http2Wrangler.js +++ b/src/network-protocol/private/Http2Wrangler.js @@ -125,6 +125,9 @@ export class Http2Wrangler extends TcpWrangler { // reference, except the reference had gotten `null`ed out). So, with that // as context, if -- as we do here -- we tell the session to close as soon // as we see the underlying socket go away, there's no internal HTTP2 error. + // Salient issues in Node: + // * + // * ctx.socket.on('close', () => { if (!session.closed) { session.close();