Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into making it possible to provide diffs like this #212

Open
orta opened this issue Apr 8, 2017 · 4 comments
Open

Look into making it possible to provide diffs like this #212

orta opened this issue Apr 8, 2017 · 4 comments

Comments

@orta
Copy link
Member

orta commented Apr 8, 2017

https://twitter.com/RReverser/status/850417946749022209

maybe? Though inline commenting #77 should provide this is probably a better format.

@tivac
Copy link

tivac commented Apr 9, 2017

I'd like the ability for both, ideally. Something about being able to have all of danger's output in a single issue comment is really appealing. Mostly for treating it like a checklist of things to take care of, I suppose.

@macklinu
Copy link
Member

This seems more like a specific use case for a dangerfile than something I see danger fully supporting. I think it'd make more sense to include an example dangerfile on the website showing some cool libraries like pinpoint or a module that creates the diff UI in the originally linked tweet.

What do y'all think? Not sure what this API would look like, so perhaps that's why I'm having trouble seeing this as a Danger feature.

@tivac
Copy link

tivac commented Aug 18, 2017

I think having a small API to make it easier to create the <details><summary> bit would be nice, if only because I don't think a lot of people realize it exists. I only learned about it from lerna and I still go copy+paste it out of their issue template because I can never remember the markup 😓

I'd also be fine w/ simply making some sort of easy-to-add plugins or something that could provide functionality like this. I don't care about it being in core necessarily, I just want it to be easy to create nice useful output.

@orta
Copy link
Member Author

orta commented Aug 18, 2017

I just saw this: PCMSolver/danger-cpp-example#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants