Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch runner tests to be integration tests #394

Closed
orta opened this issue Oct 15, 2017 · 1 comment
Closed

Switch runner tests to be integration tests #394

orta opened this issue Oct 15, 2017 · 1 comment

Comments

@orta
Copy link
Member

orta commented Oct 15, 2017

It seems very tough to test the new eval/require based dangerfile via jest in #378 ( the global object doesn't have jest/danger's DSL in it) so as a part of splitting the processes, we can have a fake DSL to input so that the 2nd process can use all the example dangerfiles to test a full integration with a stored DSL and a random dangerfile.
@orta
Copy link
Member Author

orta commented Oct 22, 2017

done in #395

@orta orta closed this as completed Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta