Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running on main #231

Open
stevehipwell opened this issue Jan 11, 2024 · 3 comments
Open

Add support for running on main #231

stevehipwell opened this issue Jan 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@stevehipwell
Copy link

I'd like to be able to run this action on main (the default branch) after merging a Dependabot PR to open a new PR to update the CHANGELOG. This would solve the issue of actions not triggering when the PR is updated. I think a basic implementation should check commits with a specific format back to the last release tag and only support updating the unreleased CHANGELOG entry.

@dangoslen
Copy link
Owner

Thanks for the idea!

Before going further, I wanted to check on this statement "actions not triggering when the PR is updated." This should be a solvable problem. You will need to create and use your own PAT instead of the auto-generated token. You can find more info on that here.

Back to your idea, I think this is possible, but it would complicate the action a little bit. I do think it would be doable. The tricky bit is that I think most of the relevant information is in the original PR, so we would need to look up the PR associated with the commit (which I do think is possible).

With that said, I'm unsure if the additional complexity is worth it, especially given that re-triggering workflows are solvable outside of this action.

Would you be willing to try issuing and using your own PAT and see if that helps solve your issue and report back? We can continue the discussion if that doesn't work out for you.

@stevehipwell
Copy link
Author

@dangoslen PAT tokens are really only suitable for personal repos. Apps are workable for enterprise scenarios but add a high level of complexity and are often impossible to self service.

Moving the responsibility to a separate PR from Dependabot significantly reduces the complexity, both in workflow and in number of workflows triggered.

@dangoslen dangoslen added the enhancement New feature or request label Jan 16, 2024
@dangoslen
Copy link
Owner

Makes sense! Thanks for the context.

I honestly don't know all that would need to be changed. Several components could be solved at the workflow level vs. the action layer (i.e. opening the PR automatically could be a workflow responsibility vs. a responsibility of this action). I imagine the core issue would be either finding commits with a specific format or by finding the original PR for the commit and reading the PR description (where I would lean). That has the benefit of at least reusing what exists in the action today.

With that said, here is where I am: I'd love to add this, but I am unsure when I will be able to do so. It feels less urgent than some of the more recent issues around multi-dependency updates or other format support.

If you would like the feature added sooner, I'm always open and happy to review a PR if you would like to add this functionality yourself! I just realistically don't know when I'll be able to find some extended time to think through it all.

@dangoslen dangoslen added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants