Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes adds a </li> #278

Open
SubJunk opened this issue May 12, 2024 · 3 comments
Open

Sometimes adds a </li> #278

SubJunk opened this issue May 12, 2024 · 3 comments

Comments

@SubJunk
Copy link

SubJunk commented May 12, 2024

Can be seen here UniversalMediaServer/UniversalMediaServer@6caa293

@dangoslen
Copy link
Owner

Interesting. Very odd bug. Will take a look!

@dangoslen
Copy link
Owner

dangoslen commented Jun 6, 2024

After much head scratching, I've realized that there is a problem in the regex that extracts the version bumps from the description. In the PR, the description has a commit that matches the regex:

2cfb474 Bump version from 18.2 to 18.3

It sounds like I need to restrict the regex here for lines that start with the initial search word. The current regex can match the line at any place in the line, which I think lead to this bug

Will see if I can tackle this soon! TY for reporting and bearing with me

@SubJunk
Copy link
Author

SubJunk commented Jun 7, 2024

Cool, it seems like a rare problem so I'm not worried, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants