Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin does not support running on sub-path #488

Closed
LaszloHont opened this issue May 23, 2019 · 4 comments
Closed

Admin does not support running on sub-path #488

LaszloHont opened this issue May 23, 2019 · 4 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@LaszloHont
Copy link

Could bitwarden_rs use relative URLs?

I don't want the world to know about https://bitwarden.example.com/ so I am using https://secure.example.com/bitwarden/. This is not findable in the SSL observatory logs, and privacy is why I am self-hosting.

I have tried starting bitwarden_rs with DOMAIN=https://secure.example.com/bitwarden/ but when I visit https://secure.example.com/bitwarden/admin/ and submit the token I get a 404 from /admin/

Thanks.

@mprasil mprasil changed the title Use relative URLs Admin does not support running on sub-path May 24, 2019
@mprasil mprasil added bug Something isn't working enhancement New feature or request labels May 24, 2019
@dani-garcia
Copy link
Owner

Running on a subdomain won't work unless you apply the patches from #241 (comment).

If the reason you are doing it is exclusively privacy, i would recommend using a less obvious subdomain, like just secure.example.com, or issuing a wildcard certificate which might not make the exact subdomain findable in those logs (I'm not sure if that's how it works, so this might not work).

As far as I know there isn't much we can do here, so I'll close this.

@gerroon
Copy link

gerroon commented Jul 2, 2019

@dani-garcia is there any reason why that patch did not make to the trunk? I personally would like to run it under a subfolder as well but I am not a coder and it seems to me that keeping up the patch with the docker updates quite a bit of involvement if you will.

@dani-garcia
Copy link
Owner

Mostly because it requires to hardcode the subfolder directly into the web vault files, which means every person would need to make a specific build for their own subfolder, so we can't distribute a generic version.

@gerroon
Copy link

gerroon commented Jul 3, 2019

I see, that maks sense. I hope this will be somehow possible in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants