Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to disable ng-extract-i18n-merge's use of HTML Character Entities like " #76

Closed
FrostKiwi opened this issue Sep 6, 2023 · 2 comments
Labels
wontfix This will not be worked on

Comments

@FrostKiwi
Copy link

Is your feature request related to a problem? Please describe.
ng-extract-i18n-merge handles certain characters as HTML Character Entities. Most prominent here is ng-extract-i18n-merge inserting " for ".
The translation platform we use, Weblate, uses the characters directly. So it inserts ". There is no need to use HTML Character Entities in Angular and Weblate replaces " with " automatically. This leads to an annoying back and forth, which fills up commit diffs.

  • Weblate removes " and inserts "
  • ng-extract-i18n-merge removes " and inserts "
  • Weblate removes " and inserts "
  • ... and so on ...

See screenshot below.

Describe the solution you'd like
A switch in angular.json to disable ng-extract-i18n-merge's use of HTML Character Entities for "builder": "ng-extract-i18n-merge:ng-extract-i18n-merge" would be nice.

Additional context
Also in the screen shot is seen ng-extract-i18n-merge misunderstanding <source> changes and resetting the translation to "new". This issue is unrelated to this one and reported in: #75

Screenshots
image

Version (please complete the following information):

  • Angular: [e.g. 13.3.0]
  • OS: [e.g. Win10]
  • nodejs: [e.g. 16.20.2]
  • ng-extract-i18n-merge version: [e.g. 2.7.1]
@daniel-sc
Copy link
Owner

@FrostKiwi this is essentially the behavior of Angulars extract-i18n, which generally makes sense - see #7.

This library could only convert quoted entities back - but this seems brittle, as angular probably does not expect unquoted special chars in the translation files..

I'd suggest, this is rather a bug / feature request for Weblate, that it should keep quoted characters and do no conversion!?

@daniel-sc daniel-sc added the wontfix This will not be worked on label Nov 9, 2023
@daniel-sc
Copy link
Owner

please comment/reopen if there is further input!

@daniel-sc daniel-sc closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants