You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a Column with type: 'date' for which the Typescript type was string | null. The plugin shows an error for that:
It proposes a Quick Fix:
However, the Quick Fix adds an unknown type of 'date'. So after the fix, the code no longer compiles:
This seems unintentional. Is it supposed to be adding the Javascript type Date (not sure if TypeORM supports that)? Or does it simply map to a string?
Both options are accepted by the plugin:
But in any case, the option added by the Quick Fix is incorrect.
The text was updated successfully, but these errors were encountered:
You are correct, it had all the types lowercased. I fixed it, so it is matching with the TypeScript types. It will be out in the next release: v0.2.6. Can you try if this corrects the fix message?
I have a Column with
type: 'date'
for which the Typescript type wasstring | null
. The plugin shows an error for that:It proposes a Quick Fix:
However, the Quick Fix adds an unknown type of 'date'. So after the fix, the code no longer compiles:
This seems unintentional. Is it supposed to be adding the Javascript type
Date
(not sure if TypeORM supports that)? Or does it simply map to astring
?Both options are accepted by the plugin:
But in any case, the option added by the Quick Fix is incorrect.
The text was updated successfully, but these errors were encountered: