Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs and vulnerabilities in code #421

Closed
AndreyAlifanov opened this issue Apr 4, 2023 · 1 comment
Closed

Bugs and vulnerabilities in code #421

AndreyAlifanov opened this issue Apr 4, 2023 · 1 comment

Comments

@AndreyAlifanov
Copy link

Hi, PVS-Studio found bugs in code. Can you fix them?
Thanks in advance.

Message: V1053: Calling the 'done' virtual function indirectly in the constructor may lead to unexpected result at runtime. Check lines: 'json_cursor.hpp:81', 'json_cursor.hpp:358', 'staj_cursor.hpp:1134'.
Type: BUG
Component: jsoncons/json_cursor.hpp
Line: 81

Message: V1053: Calling the 'done' virtual function indirectly in the constructor may lead to unexpected result at runtime. Check lines: 'json_cursor.hpp:152', 'json_cursor.hpp:374', 'staj_cursor.hpp:1134'.
Type: BUG
Component: jsoncons/json_cursor.hpp

Message: [CWE-457] V730: Not all members of a class are initialized inside the constructor. Consider inspecting: selector_.
Type: VULNERABILITY
Component: jsoncons_ext/jsonpath/expression.hpp
Line: 3055

Message: [CWE-691] V1037: Two or more case-branches perform the same actions. Check lines: 105, 111
Type: VULNERABILITY
Component: jsoncons_ext/jsonpath/json_location.hpp
Line: 105

Message: [CWE-670] V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 632, 633.
Type: VULNERABILITY
Component: jsoncons_ext/jsonpath/jsonpath_expression.hpp
Line: 633

@danielaparker
Copy link
Owner

Fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants