Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have a question BarChart #1208

Closed
shenyufei opened this issue Jul 1, 2016 · 6 comments
Closed

I have a question BarChart #1208

shenyufei opened this issue Jul 1, 2016 · 6 comments

Comments

@shenyufei
Copy link

shenyufei commented Jul 1, 2016

f5bbadb2-e9b7-4b71-9914-eadfc9c104fa

5a1aa736-aa16-4493-b402-5a546ea6d0be

As shown, the BarChart why I have the background color?

@liuxuan30
Copy link
Member

liuxuan30 commented Jul 4, 2016

I tried with ChartsDemo, not reproducing. Can you double check with ChartsDemo?
I put below code in stacked bar chart view controller
- (void)setDataCount:(int)count range:(double)range() func:

    else
    {
        set1 = [[BarChartDataSet alloc] initWithYVals:yVals label:@"Statistics Vienna 2014"];
//        set1.colors = @[[UIColor redColor]]; <--- both are fine, but you should use colors for stacked bar chart
        [set1 setColor:[UIColor redColor]];
        set1.stackLabels = @[@"Births", @"Divorces", @"Marriages"];
...

BTW, I tried color and colors, both are fine, but you should use colors for stacked bar chart

@shenyufei
Copy link
Author

shenyufei commented Jul 4, 2016

Not the case, this is BarChart, not Stacked bar, you take a closer look at my code is barchardataEntry (value), not values, but why he had the appearance of stacked bar? I have seen ChartsDemo, this is CombinedChart. @liuxuan30
And, even if I was stacked bar, but I only add a number, so it should not be two bar, but now he is so, so I ask the question

@liuxuan30
Copy link
Member

liuxuan30 commented Jul 4, 2016

well.. I don't know what have you changed, but one simple fact is that ChartsDemo is fine. I am not using ChartsDemo as an excuse, but it's much more efficient you can try it and compare with your code.

You could try add some breakpoint in bar chart renderer to see how it renders your bars. first make sure the bar rect is correct, second make sure the color is right. I doubt if you changed anything like background color etc in your code

@shenyufei
Copy link
Author

shenyufei commented Jul 5, 2016

I checked for a long time, but still did not check out what is wrong, I did not set anything else, I again wrote a Demo, but still, as the code is very simple, I do not see where the wrong, why is it so?

`

func setchart()  {
    let data = CombinedChartData(xVals: month)
    data.lineData = returnLine()
    data.barData = returnBar()
    comboChart.data = data

}

func returnLine() -> LineChartData {
    let d = LineChartData()
    var entries = [ChartDataEntry]()
    for i in 0...month.count - 1{
        let val1 = ((Double)(arc4random_uniform(UInt32(35))) + 100)
        entries.append(ChartDataEntry(value: val1, xIndex: i))
    }

    let set = LineChartDataSet(yVals: entries, label: "LineDataSet")
    set.setColor(UIColor.greenColor())
    set.lineWidth = 2.5
    set.axisDependency = .Right
    d.addDataSet(set)
    return d
}

func returnBar() -> BarChartData {
    let d = BarChartData()
    var entries = [BarChartDataEntry]()
    for i in 0...month.count - 1{
        let val1 = ((Double)(arc4random_uniform(UInt32(35))) + 100)
        entries.append(BarChartDataEntry(value: val1, xIndex: i))
    }
    let set = BarChartDataSet(yVals: entries, label: "BarDataSet")
    set.setColor(UIColor.blueColor())
    set.axisDependency = .Left
    d.addDataSet(set)
    return d
}

`
8f67b7db-0540-451e-aac9-29261c69c4f3

@liuxuan30

@liuxuan30
Copy link
Member

I believe you turned on drawBarShadowEnabled. It's true by default for combined chart.

liuxuan30 added a commit to liuxuan30/Charts that referenced this issue Jul 6, 2016
@liuxuan30
Copy link
Member

I am filing a PR for the default value

@liuxuan30 liuxuan30 reopened this Jul 6, 2016
danielgindi added a commit that referenced this issue Aug 14, 2016
for #1208, seems drawBarShadowEnabled should be false by default
liuxuan30 added a commit that referenced this issue Sep 1, 2016
migrate Chart v3 code in master to swift 2.3 syntax (#1387)

* upgrade carthage to 0.17.1

* use master commit for iso-snapshot-test-case for now. once the fix is tagged we could change to the new version

* change Rakefile, comment out tvOS because no FBSnapshotTestCase

* Add missing imports for iOS 7 support

* Update ChartSelectionDetail.swift

* BUGFIX: fix infinite recursive call of getXIndex(_:)

* for #1208, seems drawBarShadowEnabled should be false by default

* 1. update ios-snapshot-test-case to 2.1.2
2. remove brew upgrade carthage, because travis saying

* improve descriptions to warn users how to use setVisibleRange APIs

* Typo fix

* upgrade Realm to 1.0.2

* update Realm pod spec to 1.0.2

* fix pod spec typo

* Work on x-values instead of x-indices (free for all :-)

* Improvement for pie slice spacing calculation

* Example improvements

* Docs improvements

* Major work on highlights

* ChartMarker is now a protocol, and we have ChartMarkerView/Image helpers

* Improvements regarding irrelevant inherited methods

* Added feature to change color of "no data" text

* More work on highlights

* Viewport enhancements for better horizontal bar support

* X-axis renderer enhancements for better horizontal bar support

* Minor improvement to valueFormatter

* Completed copy routine for scatter dataset

* Pie: Renamed `drawSliceTextEnabled` to `drawEntryLabelsEnabled`

* Pie: Added feature to offset center text

* Pie: Separate color/font for entry labels (defaults to value color/font)

* Minor improvements to demo

* Minor refactoring of variable names

* Example cleanup

* Refactored scatter shape rendering into interface and renderers

* Improved docs

* Removed deprecated --var / var--

* Update README.md

* Dropped iOS 7.0 support from README (Closes #601)

* Fixed a RadarChart bug where value labels were misplaced

* Realm fixes

* Improvements to zoom methods

* Legend improvements

* DRYed some code

* Adjusted maxHighlightDistance defaults

* Removed NaN check for highlight.

* Cleanup these comments

* `drawBarShadowEnabled` is working again

* Do not invalidate here by default, like other zoom methods

* Simplified scatter shape enum model

* These return a single pixel (x/y), for values (x value and y value)

* Renamed x-pos to x-value where appropriate

* Renamed ChartMarker -> IChartMarker

* Namespace `Marker` names only for Objc (Swift 2.2)

The Charts v3 changes are a chance to do this,
  as it's a breaking change anyway.

* Do not force unwrap here

* Fix for comments

* More improvements to Markers, default behaviour constraint to view size

* Docs

* The highlight breaking changes are a chance to use @objc(name) feature

* Use @objc(name) feature for rarely used classes (by users)

* Improved entryIndex rounding method

* Fixed drawing bounds for some of the charts

* Removed unused yValueForXValue / yValuesForXValue

* Set a default shape renderer

* Take the correct barData object here

* Fixed combined chart highlight with bar data

* Minor refactoring

* Removed the extra offset that messed up legend location

* Cache XBounds object

* Breaking change: `valueFormatter` now accepts an IValueFormatter

This allows for formatting depending on viewport state etc.

* Avoid x values in Pie's calcMinMax

* This workaround is not required in the newer compilers

* Renamed formatter interfaces

FillFormatter -> IFillFormatter
ValueFormatter -> IValueFormatter
AxisValueFormatter -> IAxisValueFormatter

* Avoid truncating using Int(...), it overflows

* Corrected formula for 29-feb :-)

* Some minor bug fixes for formatters

* Polished demos

* More improvements to examples

* These should be internal

* Fixed xAxis min/max calculation typo

* Added helper to generate a fill formatter with a closure (block)

* Added more samples

* Updated tests

* Set default barWidth to match old default behaviour

* Renamed axisMinValue/axisMaxValue to axisMinimum/axisMaximum

* Cleaned up header comments

(I know that most of these files were created by me, I don't need that
 in the headers...)

* Removed deprecated startAtZero properties

* When only one of scaleXEnabled or scaleYEnabled is effective

* Docs

* Cleanup

* Use EPSILON instead of an arbitrary value (Fixes #1239)

* Fix dataset update in Dual line chart demo (Fixes #1250)

* Add half line width to clipping rect of grid/limit lines (Fixes #1204)

* Simplified legend entries configuration. Option to style dataset form.

(Closes #1282)

* Added feature for dashing legend line forms

* Change default formLineWidth to match the default on MPAndroidChart

* neededWidth should be enough here. formSize has no meaning globally.

If more offset is needed - use extraOffsets, or adjust the maxSizePercent).

* Renamed those classes too. Cleaner now. Should be too breaking...

As with swift's minimal syntax - the chance of anyone referencing
  those by name is very low.
On ObjC, the names stayed the same, for namespacing.

* Take care of edge cases when calculating intervals (labelCount == 0)

* autoScaleMinMax is working again (Fixes #1209)

* Minor refactoring (Closes #1187)

Sorry, un-mergable to `master`...

* Fixed reversed condition from cbd7bf7

* It's clearer this way

* Fill before stroke - because the fill may cover half of a thick stroke

(Closes #982)

* Added those new classes to tvOS/macOS targets

* Migrated viewFromXib to macOS

* Call `print` under `Swift` namespace, due to Cocoa ambiguity in NSView

* Migrated macOS demos to Charts 3.0

* Use an optional for _displayLink (Fixes #1336)

_displayLink might not have been created, i.e. in Interface Builder context.

* Corrected LineChartRenderer cubicFill x range

* Fixed horizontal cubic calculation bug introduced when removing x-index

* Avoid using deprecated property in demo

* Updated test screenshots

* Animating the wrong axis for the starting point

* migrate Chart v3 code in master to swift 2.3 syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants