Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS demo bar chart's first and last bar got half cut #1468

Closed
liuxuan30 opened this issue Sep 19, 2016 · 4 comments
Closed

macOS demo bar chart's first and last bar got half cut #1468

liuxuan30 opened this issue Sep 19, 2016 · 4 comments
Labels

Comments

@liuxuan30
Copy link
Member

liuxuan30 commented Sep 19, 2016

on master branch, macOS demo bar chart's first and last bar got half cut. Another post #1446 mentioned similar, however it's about fitBars=true. OS X demo disabled fitBar still face same issue.
Will look into if free or someone can catch.

macosbug

@liuxuan30 liuxuan30 added the bug label Sep 19, 2016
@liuxuan30 liuxuan30 changed the title OS X demo bar chart's first and last bar got half cut macOS demo bar chart's first and last bar got half cut Sep 19, 2016
@danielgindi
Copy link
Collaborator

@PhilJay I'm guessing that a bar at x=0.0, will get cut on the left as there's a bar width that gets from -0.5 to 0.5 right?

@PhilJay
Copy link
Collaborator

PhilJay commented Sep 19, 2016

Yes, exactly. The fitBars(true) method should fix that. :-)

@danielgindi
Copy link
Collaborator

There was a bug with fitBars implementation here, fixed :-)

@liuxuan30
Copy link
Member Author

liuxuan30 commented Sep 20, 2016

@danielgindi I did check fitBars are turned off and having the issue. With #1452 and #1486 it's fixed if we turn it on. However, If fitBars turned off, seeing cutting off is expected? By default it's false, kind of confused here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants