Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChartViewDelegate's chartValueSelected is tied up with Highlights #1614

Closed
UberJason opened this issue Oct 6, 2016 · 3 comments
Closed

ChartViewDelegate's chartValueSelected is tied up with Highlights #1614

UberJason opened this issue Oct 6, 2016 · 3 comments

Comments

@UberJason
Copy link

I noticed that the ChartViewDelegate method chartValueSelected is tied up with Highlights, meaning it fires when you highlight a bar and doesn't fire when you de-highlight a bar (instead, chartValueNothingSelected is called). That's great, but when highlightEnabled is set to false, neither method fires when a bar is tapped. It would be awesome if these two could be untangled in that situation - if highlightEnabled is false, tapping the bar should always fire chartViewSelected, just like it's a simple tap gesture recognizer.

@liuxuan30
Copy link
Member

maybe some format for your text.. hard to read.
It depends on different needs. Some people thought highlightEnabled is false should not trigger any highlight behavior at all..
you are the first to ask this.

@UberJason
Copy link
Author

Maybe a second flag then, to decouple the tap gesture recognizer from the highlighter? Having a tap gesture recognizer that just fires on all taps feels more like a standard iOS API, it would be great to have this.

@danielgindi
Copy link
Collaborator

chartViewSelected is not a tap recognizer. If you want a UITapGestureRecognizer, then add one.
chartViewSelected is not fired when there's no selection, because there's no selection, I think it's plain English and it makes sense...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants