Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'spaceBetweenLabels' not found on object XAxis #1643

Closed
WYZKirk opened this issue Oct 11, 2016 · 5 comments
Closed

'spaceBetweenLabels' not found on object XAxis #1643

WYZKirk opened this issue Oct 11, 2016 · 5 comments

Comments

@WYZKirk
Copy link

WYZKirk commented Oct 11, 2016

Hello,
I cannot found spaceBetweenLabels on object XAxis.
Was this property updated with a new name?

@louisdh
Copy link

louisdh commented Oct 12, 2016

It seems this property was removed in commit 3dbd57b by @danielgindi. I'm not sure what the replacement is.

@TheAbhiGoyal
Copy link

Similarly setLabelsToSkip is missing. What are the respective replacements, if any?

@danielgindi
Copy link
Collaborator

There is no such thing anymore, as there are not x-indexes anymore.

We cannot skip x labels, because there's no whole number to compare against.
If we had an array of x-indexes [0,1,2,3,4,5], we could say that we want to skip 1, and show [0,2,4].
But now that we have x-values, say that we have [0, 0.23, 0.73, 2, 2.9, 3.2, 3.5, 3.7, 4.2, 5.1]... What exactly would we skip?

@danielgindi
Copy link
Collaborator

There is no more spaceBetweenLabels, as there's no constant distance between values. The values are not on whole indexes anymore (0,1,2,3,4,5) but on decimal values [0, 0.7, 1.2, 1.73, 2...], so there's no point in spaceBetweenLabels anymore.

@brenoBohm
Copy link

@danielgindi And when I use a custom value in my xAxix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants