Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can i use 2.2.5 version with Swift3 #1700

Closed
mecid opened this issue Oct 22, 2016 · 16 comments
Closed

Can i use 2.2.5 version with Swift3 #1700

mecid opened this issue Oct 22, 2016 · 16 comments

Comments

@mecid
Copy link

mecid commented Oct 22, 2016

How can i use 2.2.5 version with Swift3?

@danielgindi
Copy link
Collaborator

You might be able to - but the conversion from Swift 2 to 3 is tedious, and we do not intend to do so.
Please consider moving to Charts 3.0 - as it not only written in Swift 3.0, but it has also great new features and many bug fixes.

@mecid
Copy link
Author

mecid commented Oct 23, 2016

@danielgindi i dont like changes in 3.0 version like removing xVals.
Are you removed chats2.2.5-Swift3 branch?

@mecid
Copy link
Author

mecid commented Oct 25, 2016

@danielgindi maybe you can give me some answers on my questions before close the issue?

@pmairoldi
Copy link
Collaborator

X values have not gone away. If you read the release notes of v3.0 you can see the migration. v2.3 of charts supports swift 2.3 and is the same interface as 2.2.5. Swift 3 will only be supported by charts v3 and we deleted the branches since we are no longer supporting them. They were temporary

@mecid
Copy link
Author

mecid commented Oct 26, 2016

@petester42 thanks for your response.
But this is wrong way, users must have the opportunity to select version.
I need to fix minor bug, but now cocoapods cant load the branch and i need to apply massive changes to my code base.

@pmairoldi
Copy link
Collaborator

Users can select a version. Charts 2.3 supports swift 2.3. Charts 3.0 supports swift 3.0.

You were using an unrealeased version of our library. If that affects your code base that sucks but that's sometimes what happens when you try out the bleeding edge. We can't be held responsible for something we said we wouldn't support.

You are already converting your code to swift 3 which is a elaborate process. Why not also update to charts 3 since you are essentially refactoring your application anyways.

@mecid
Copy link
Author

mecid commented Oct 26, 2016

@petester42 i am uploaded app before iOS10 release. Now i fixed some bug, but i need to migrate to charts3 before release fix and this is ugly.

@pmairoldi
Copy link
Collaborator

We are doing this on our own time. For us it didn't make sense for us to support both swift versions due to time constraints.

@liuxuan30
Copy link
Member

@petester42 there used to be a branch for this, but it's gone..

@pmairoldi
Copy link
Collaborator

Yes. I deleted it once 3.0 became final. Since we have no plans to support it we shouldn't keep a branch around since people will us it and ask for bug fixes and such for that branch. Just like this issue.

@liuxuan30
Copy link
Member

ok, I see.
@mecid maybe take swift 2.3 for iOS 10 first.. and then swift 3.0. It's not worthy to convert for swift 3.0, too many changes.

@mecid
Copy link
Author

mecid commented Oct 27, 2016

@liuxuan30 my app released with swift3...

@liuxuan30
Copy link
Member

liuxuan30 commented Oct 31, 2016

I checked my repo - https://github.com/liuxuan30/Charts/tree/Swift-3.0, it seems a Chart 2.2.5 + Swift 3.0 version.
You can take it for your needs. And fix bugs if you saw any..

@mecid
Copy link
Author

mecid commented Oct 31, 2016

@liuxuan30 thanks ;)

@L-Jovi
Copy link

L-Jovi commented Nov 28, 2016

@liuxuan30 thanks for your Swift-3.0 branch !

@liuxuan30
Copy link
Member

liuxuan30 commented Nov 29, 2016

@L-Jovi migrate to 3.0, it is painful to upgrade but also more flexible!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants