-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can i use 2.2.5 version with Swift3 #1700
Comments
You might be able to - but the conversion from Swift 2 to 3 is tedious, and we do not intend to do so. |
@danielgindi i dont like changes in 3.0 version like removing xVals. |
@danielgindi maybe you can give me some answers on my questions before close the issue? |
X values have not gone away. If you read the release notes of v3.0 you can see the migration. v2.3 of charts supports swift 2.3 and is the same interface as 2.2.5. Swift 3 will only be supported by charts v3 and we deleted the branches since we are no longer supporting them. They were temporary |
@petester42 thanks for your response. |
Users can select a version. Charts 2.3 supports swift 2.3. Charts 3.0 supports swift 3.0. You were using an unrealeased version of our library. If that affects your code base that sucks but that's sometimes what happens when you try out the bleeding edge. We can't be held responsible for something we said we wouldn't support. You are already converting your code to swift 3 which is a elaborate process. Why not also update to charts 3 since you are essentially refactoring your application anyways. |
@petester42 i am uploaded app before iOS10 release. Now i fixed some bug, but i need to migrate to charts3 before release fix and this is ugly. |
We are doing this on our own time. For us it didn't make sense for us to support both swift versions due to time constraints. |
@petester42 there used to be a branch for this, but it's gone.. |
Yes. I deleted it once 3.0 became final. Since we have no plans to support it we shouldn't keep a branch around since people will us it and ask for bug fixes and such for that branch. Just like this issue. |
ok, I see. |
@liuxuan30 my app released with swift3... |
I checked my repo - https://github.com/liuxuan30/Charts/tree/Swift-3.0, it seems a Chart 2.2.5 + Swift 3.0 version. |
@liuxuan30 thanks ;) |
@liuxuan30 thanks for your Swift-3.0 branch ! |
@L-Jovi migrate to 3.0, it is painful to upgrade but also more flexible! |
How can i use 2.2.5 version with Swift3?
The text was updated successfully, but these errors were encountered: