Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChartsDemo dependency on realm-cocoa ~> 1.1 issue #1748

Closed
DanielAsher opened this issue Oct 30, 2016 · 3 comments
Closed

ChartsDemo dependency on realm-cocoa ~> 1.1 issue #1748

DanielAsher opened this issue Oct 30, 2016 · 3 comments

Comments

@DanielAsher
Copy link

Hi,
Thanks for the great project! I'm very much looking forward to exploring and contributing.

I notice the ChartsDemo project has a realm-cocoa ~> 1.1 dependency that Charts does not require. Would it be possible to remove this requirement from the main library?

many thanks,
Daniel

@danielgindi
Copy link
Collaborator

The library has no dependency on Realm. It's only the demo that requires Realm, as it demonstrates Realm use too.
You can compile against Charts as you always did.

@DanielAsher
Copy link
Author

Apologies for the double issue posting.
Perhaps I am misusing Carthage. It is certainly true that there is no dependency in the library, but I have found that a project using the Charts Cartfile will have realm-cocoa pinned at v1.1. I am unable to run carthage update with my realm-cocoa v2.0 dependency being respected.

@pmairoldi
Copy link
Collaborator

Ya that would be an issue with Carthage. We can't specify subspecs like cocoapods so we need to include all possible dependencies in our Cartfile. You could send a pull request updating the realm version and I'll gladly merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants