-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo code can't run #2066
Comments
Hey @zip520123 try this: First copy the Cartfile from /Charts-master to /Charts-master/ChartsDemo Then from /ChartsDemo instead of
Now open the ChartsDemo project in Xcode, select the Target and under the General tab go to Embedded Binaries and delete the existing Realm.framework entry Then drag Realm.framework and RealmSwift.framework from /Charts-master/ChartsDemo/Carthage/Builds/iOS into Embedded Binaries (Don't check "copy if needed") Build and run. Should work now! |
I thought I added a script that automatically downloads the dependencies for the demo. Maybe I only added it to the framework. I'll look into it. |
@petester42 Seems like RealmSwift.framework isn't embedded in the demo project. I realized too late but a simpler solution to my quick fix above might be just to drag RealmSwift.framework from /Charts-master/Carthage/Builds/iOS into Embedded Binaries |
It work. |
@Mossby bingo! good job :] |
oops, reopen as @petester42 is looking into it |
I saw @danielgindi added RealmSwift in RealmBaseDataSet.swift, but currently ChartsDemo does not have that framework under frameworks. Simply drag RealmSwift.framework into that folder and re-embed it and things went well then: |
Realm swift is referenced in ChartsRealm.framework now |
@petester42 I had a PR #2083 for adding RealmSwift into project settings. |
😂 just saw yours, closing my poor one |
I just submitted mine. It also fixes the test target not running. |
* commit '853237172914b276809d5a821455f76eea67c766': Adds NSPhotoLibraryUsageDescription to plist of ChartsDemo to prevent crash on iOS 10 on try to store shot of char to photo library. update rakefile for ios 10.x simulators close ChartsOrg#2066 fix a typo, as orientation is horizontal by default update configurations for xcode 8.2 Update RealmSwift Dependency Fix NSCopying implementation in CandleChartDataEntry Add support for extensions
I clone demo code and try to run.
follow readme."Having trouble running the demo?"
Run
got
And I try to run it on my iPhone then crash.
The text was updated successfully, but these errors were encountered: