Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]negative values rendering +highlight rect rendering not correct for stacked bar + stacked horizontal bar chart #212

Closed
liuxuan30 opened this issue Jul 14, 2015 · 3 comments

Comments

@liuxuan30
Copy link
Member

It looks like if the dataSet contains negative values for stacked bar + stacked horizontal bar chart, it cannot render correctly.

It's very easy to reproduce, just change the values inside the demo to negative.

I am not sure if you are aware of this, either we need to define how to render and highlight the stacked bar chart + stacked horizontal bar chart for negative values.
negabarbug

@danielgindi
Copy link
Collaborator

What version are you using? Because we fixed that already

@liuxuan30
Copy link
Member Author

I believe it's the latest code? I just synced yesterday. Could you privde some IDs so I can track on my side? I don't see a conflict while pulling.

This is what I changed for stacked bar chart dataSet, just add - before each value:

    for (int i = 0; i < count; i++)
    {
        double mult = (range + 1);
        double val1 = -(double) (arc4random_uniform(mult) + mult / 3);
        double val2 = -(double) (arc4random_uniform(mult) + mult / 3);
        double val3 = -(double) (arc4random_uniform(mult) + mult / 3);

        [yVals addObject:[[BarChartDataEntry alloc] initWithValues:@[@(val1), @(val2), @(val3)] xIndex:i]];
    }

@liuxuan30
Copy link
Member Author

are you saying the fix isFixed highlights in negative stacked bar chart(ade153a)?
If that is the case, then I think it is not fixed... at least for pure negative values. The rendering and highlight both go wrong.

@liuxuan30 liuxuan30 changed the title negative values rendering +highlight rect rendering not correct for stacked bar + stacked horizontal bar chart [BUG]negative values rendering +highlight rect rendering not correct for stacked bar + stacked horizontal bar chart Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants