Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PieChart highlightValue(x:y:dataSetIndex:) should provide error for dataSetIndex > 1 #3146

Closed
jjatie opened this issue Jan 2, 2018 · 3 comments · Fixed by #3286
Closed

PieChart highlightValue(x:y:dataSetIndex:) should provide error for dataSetIndex > 1 #3146

jjatie opened this issue Jan 2, 2018 · 3 comments · Fixed by #3286
Labels
bug
Milestone
3.1

Comments

@jjatie
Copy link
Collaborator

jjatie commented Jan 2, 2018

The issue in #2862 should provide feedback in the console that PieCharts can only accept an dataSetIndex == 0
@jjatie jjatie added the bug label Jan 2, 2018
@liuxuan30
Copy link
Member

I'm trying to add some issues you mentioned and can be fixed for 3.1

@liuxuan30 liuxuan30 added this to To Do in 3.1 release Feb 17, 2018
@jjatie jjatie added this to the 3.1 milestone Feb 21, 2018
@liuxuan30
Copy link
Member

I believe you can solve this right?
I'm taking #3244 tomorrow.

@liuxuan30 liuxuan30 moved this from To Do to In progress in 3.1 release Feb 22, 2018
liuxuan30 added a commit that referenced this issue Feb 22, 2018
@liuxuan30
for #3146. add a warning message if pie chart has more than one data set
c9bf692
@liuxuan30 liuxuan30 mentioned this issue Feb 22, 2018
Merged
@liuxuan30
Copy link
Member

liuxuan30 commented Feb 22, 2018 •
edited

Turned out #3244 is invalid so far, so I finish off this instead.

@liuxuan30 liuxuan30 removed this from In progress in 3.1 release Feb 22, 2018
liuxuan30 added a commit that referenced this issue Mar 20, 2018
@liuxuan30
use assert instead of warning if pie chart data set > 1
db7f9dd 
for #3146. add a warning message if pie chart has more than one data set
liuxuan30 added a commit that referenced this issue Mar 20, 2018
@liuxuan30
put assert into getter (+1 squashed commit)
6ce557d 
Squashed commits:
[db7f9dd] use assert instead of warning if pie chart data set > 1
for #3146. add a warning message if pie chart has more than one data set
liuxuan30 added a commit that referenced this issue Mar 20, 2018
@liuxuan30
put assert into getter (+1 squashed commit)
ed8cf20 
Squashed commits:
[db7f9dd] use assert instead of warning if pie chart data set > 1
for #3146. add a warning message if pie chart has more than one data set
liuxuan30 added a commit that referenced this issue Mar 20, 2018
@liuxuan30
Merge pull request #3286 from danielgindi/3146
f7a648c 
for #3146. add a warning message if pie chart has more than one data set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

for #3146. add a warning message if pie chart has more than one data set ChartsOrg/Charts
2 participants
@liuxuan30 @jjatie