Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo is not compiling #3469

Closed
1 task done
dlargen33 opened this issue May 23, 2018 · 7 comments
Closed
1 task done

Demo is not compiling #3469

dlargen33 opened this issue May 23, 2018 · 7 comments

Comments

@dlargen33
Copy link

dlargen33 commented May 23, 2018

ℹ Please fill out this template when filing an issue.
All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.

Per our *CONTRIBUTING guidelines, we use GitHub for
bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag ios-charts.

Please remove this line and everything above it before submitting.

What did you do?

Pulled down the zip file from master, opened the ChartsDemo-iOS project file, and tried to compile for the simulator iPhone 8

What did you expect to happen?

Should have compiled

What happened instead?

In files LineChartTimeViewController.swift, DemoBaseViewController.swift, DayAxisValueFormatter.swift, and LineChartFilledViewController.swift I am getting compiler error "No Such Module Charts"

Charts Environment

**Charts version/Branch/Commit Number: Master
**Xcode version: 9.3.1
**Swift version: 4.1
**Platform(s) running Charts: iOS 11.3
**macOS version running Xcode: 10.13.4

Demo Project

@dgaedcke
Copy link

cd
pod install

then try compiling again

@dlargen33
Copy link
Author

dlargen33 commented May 23, 2018 via email

@liuxuan30
Copy link
Member

it shouldn't. The demo comes with the chart project.
image

double check on your side.

@dlargen33
Copy link
Author

dlargen33 commented May 24, 2018 via email

@liuxuan30
Copy link
Member

liuxuan30 commented May 28, 2018

well.. I just tried again same as what you said exactly and it's working without issue. Clearly something wrong with your setup, so you should ask on stack overflow or just clean and rebuild.

We don't answer Xcode related issue itself, unless you sure it's the library's bug.

@dlargen33
Copy link
Author

dlargen33 commented May 28, 2018 via email

@liuxuan30
Copy link
Member

liuxuan30 commented Jun 4, 2018

couldn't be masked env on my side. My git is totally clean, and build from scratch. That's why I asked you to stack overflow. The project is built to be able to run on any new machine, as long as you have the latest Xcode.

BTW, there are more chances to fail if you use pod than build from the source. anyway, continue to dig or just abandon and focus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants