Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 Support w/ Cocoapods #3913

Closed
1 task done
jlaws opened this issue Mar 26, 2019 · 2 comments
Closed
1 task done

Swift 5 Support w/ Cocoapods #3913

jlaws opened this issue Mar 26, 2019 · 2 comments

Comments

@jlaws
Copy link

jlaws commented Mar 26, 2019

What did you do?

Built the pod with Xcode 10.2

What did you expect to happen?

No warning to convert Charts.framework to Swift 5

What happened instead?

Xcode created a warning to migration Charts.framework to Swift 5

Charts Environment

Charts version/Branch/Commit Number: Cocoapod version 3.2.2
Xcode version: 10.2
Swift version: 5
Platform(s) running Charts: iOS
macOS version running Xcode: 10.14.3

Demo Project

any project running in Xcode 10.2 will display the warning.

@jlaws jlaws changed the title Swift 5 Support Swift 5 Support w/ Cocoapods Mar 26, 2019
@liuxuan30
Copy link
Member

let's route swift 5 PRs to #3874 add anything you found missing in that PR. thanks

@jlaws
Copy link
Author

jlaws commented Apr 17, 2019

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants