Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cubic line goes over the last point #683

Closed
jitu89 opened this issue Jan 18, 2016 · 4 comments
Closed

Cubic line goes over the last point #683

jitu89 opened this issue Jan 18, 2016 · 4 comments
Labels
bug

Comments

@jitu89
Copy link

jitu89 commented Jan 18, 2016

linebar

The line is coming out of the circle for the first point when it is cubic

kindly help me in getting solution
@liuxuan30
Copy link
Member

I d see this in ChartsDemo combined chart, while zooming in.

@danielgindi
Copy link
Collaborator

I do not see this in the demo. Was this maybe solved already by another cubic fix?

@danielgindi
Copy link
Collaborator

Oh wait. I do see this.

@danielgindi danielgindi changed the title Issue in combine Chart Line cubic Cubic line goes over the last point Mar 17, 2016
@danielgindi danielgindi mentioned this issue Mar 17, 2016
Closed
danielgindi added a commit to danielgindi/MPAndroidChart that referenced this issue Mar 17, 2016
@danielgindi
Fixed cubic line "leak" on first point.
f002a3a 
Since lately we've done many fixes to the calculation for first/last
  points in cubic drawing - we not do not need that first "add curve".

Related issue: ChartsOrg/Charts#683
@danielgindi
Copy link
Collaborator

Yay! :-)

@danielgindi danielgindi mentioned this issue Mar 17, 2016
Merged
regas99 pushed a commit to regas99/MPAndroidChart that referenced this issue Apr 1, 2019
@danielgindi
Fixed cubic line "leak" on first point.
1eb4e0d 
Since lately we've done many fixes to the calculation for first/last
  points in cubic drawing - we not do not need that first "add curve".

Related issue: ChartsOrg/Charts#683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielgindi @jitu89 @liuxuan30