Infinite loop when setting data on ChartDataEntry object

[justinswart]

I'm setting additional data on the ChartEntryObject to pass it to the Marker view:

for accountBalance in accountBalances
{
    var entry = ChartDataEntry(value: accountBalance.amount.floatValue, xIndex: count++)
    entry.data = dateFormatter.stringFromDate(accountBalance.date)

    yVals.append(entry)
}

This causes EXC_BAD_ACCESS infinite loop in ChartDataEntry.swift:

The problem is fixed by changing line 64 of ChartDataEntry.swift from:

if (object!.data !== data && !object!.isEqual(self))

to

if (object!.data !== data)

Is it safe to do so?

[danielgindi]

Actually it isn't, the correct fix would be to changed line 54 to be === instead of ==

Thanks for the catch :-)

[justinswart]

Hi, thanks for the quick reply. I changed that line as you suggested but it's now causing EXC_BAD_ACCESS on the line that I thought may be the problem:

Making this change does appear to fix it:

if (object!.data !== data)

I'm new to Swift so I'm just not sure of the full implications of this. Is !object!.isEqual(self) not somehow causing an infinite isEqual() loop on itself?

[danielgindi]

It was just another thing I missed. It should have been isEqual(data)... A commit coming right up.

[justinswart]

Thanks!