-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highestVisibleXIndex has regression issue #985
Comments
Fixed in Charts 3.0 (v3 branch) |
Is it a fix or a new implementation so this is solved automatically? If so I will close #1000 |
The whole X concept changed, so it's a new implementation. For x indexes there were reasons for both sides, used in multiple situations- now the situation does not exist :) |
@danielgindi
for 375d7ba, you mentioned this closes for #785, #794
However, my old PR: 862de89 was trying to fix other issue.
I think we need review these two commits for highestVisibleXIndex? I had regression on my side:
pt.x now is 25.0, if we print it, but in the mem, it looks like 24.999999993, so floor(pt.x) would be 24, while it should be 25.0?
The text was updated successfully, but these errors were encountered: