Added a check against NaN #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There needs to be a check against NaN after ChartUtils::roundToNextSignificant() returns.
Current coverage is 18.83% (diff: 100%)@@ master #1733 diff @@
==========================================
Files 123 123
Lines 14052 13941 -111
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2626 2626
+ Misses 11426 11315 -111
Partials 0 0
|
|
Could you add tests for this change? |
|
under what situation it is NaN? |
|
root caused in #1737 comments. Due to 32 bit double min. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There needs to be a check against NaN after ChartUtils::roundToNextSignificant() returns.