Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 8.3 compiler warnings #2279

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Fix Xcode 8.3 compiler warnings #2279

merged 1 commit into from
Mar 28, 2017

Conversation

krbarnes
Copy link
Contributor

Xcode 8.3 introduces a bunch of new compiler warnings. This PR fixes them.

  • Replace M_PI_2 with Double.pi / 2
  • Replace M_PI with Double.pi
  • Replace DBL_MAX with Double.greatestFiniteMagnitude
  • Replace DBL_EPSILON with Double.ulpOfOne

@codecov-io
Copy link

codecov-io commented Mar 25, 2017

Codecov Report

Merging #2279 into master will increase coverage by 0.14%.
The diff coverage is 33.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2279      +/-   ##
==========================================
+ Coverage   18.44%   18.58%   +0.14%     
==========================================
  Files         124      124              
  Lines       14619    14508     -111     
==========================================
  Hits         2696     2696              
+ Misses      11923    11812     -111
Impacted Files Coverage Δ
Source/Charts/Animation/ChartAnimationEasing.swift 0% <ø> (ø) ⬆️
...Data/Implementations/Standard/ChartDataEntry.swift 6.45% <0%> (ø) ⬆️
Source/ChartsRealm/Data/RealmBaseDataSet.swift 0% <0%> (ø) ⬆️
Source/Charts/Highlight/RadarHighlighter.swift 0% <0%> (ø) ⬆️
Source/ChartsRealm/Data/RealmBubbleDataSet.swift 0% <0%> (ø) ⬆️
Source/ChartsRealm/Data/RealmBarDataSet.swift 0% <0%> (ø) ⬆️
.../Implementations/Standard/ChartDataEntryBase.swift 8.33% <0%> (ø) ⬆️
...a/Implementations/Standard/CombinedChartData.swift 0% <0%> (ø) ⬆️
Source/Charts/Renderers/PieChartRenderer.swift 0% <0%> (ø) ⬆️
Source/ChartsRealm/Data/RealmCandleDataSet.swift 0% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e17ca...e72fe90. Read the comment docs.

@liuxuan30
Copy link
Member

liuxuan30 commented Mar 27, 2017

It has merged already. update your repo.
BTW, I don't see it complains about M_PI and EPSILON, but greatestFiniteMagnitude has been updated.

@liuxuan30 liuxuan30 closed this Mar 27, 2017
@liuxuan30
Copy link
Member

oops, sorry, I missed yo said Xcode 8.3 errors.

@liuxuan30 liuxuan30 reopened this Mar 28, 2017
This was referenced Mar 28, 2017
@liuxuan30
Copy link
Member

should be fine to merge.

@liuxuan30 liuxuan30 merged commit aa22439 into ChartsOrg:master Mar 28, 2017
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Fix Xcode 8.3 compiler warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants