-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixing with one line, updating ChartViewBase.swift #2355
Conversation
fixing a bug: when clearing chart, the 'lastHighlighted' var isn't set to nil. This will cause user to tap twice to highlight the new value, if the new value's index is the same as the old 'lastHighlighted' var's.
do you mean you called |
I tried to highlight the first bar in my barChart, then I press a button to remove old data and fill in new ones, but I find out you need to tap twice to highlight the first bar of new data. And I don't know how to "set the new chart data directly" without calling
Function |
What I mean is just call |
I see. The If you can add a switch for it, I think I can manage to merge this PR, or I will do it later. |
Ok, I'll try it when I have time |
it controls whether to clear the lasthighlighted value or not
looks good to me. we will try fix travis first, and later handle some simple PRs, thanks for you patience. |
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
=========================================
Coverage ? 19.66%
=========================================
Files ? 112
Lines ? 13713
Branches ? 0
=========================================
Hits ? 2696
Misses ? 11017
Partials ? 0
Continue to review full report at Codecov.
|
…l/update_upstream * commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits) add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355) update schemes, move script to file like ChartsRealm use name instead of uuid, add run script for copying missing framework for ChartsTests 1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365) Converted swift 3.0 DBL_MIN leftover Removed leftover script from the combined Realm era Removed leftover scheme v3.0.2 Removed unrequited script gitignore updates Added @discardableResult to silence warnings when it’s safe to ignore result Moved Realm stuff to https://github.com/danielgindi/ChartsRealm Remove line width minimum constraint Updated build-dependencies.sh loosen realm version requirement fix Xcode 8.3 compiler warnings fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it Updated to use Realm version 2.4.3 Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart ... # Conflicts: # Source/ChartsRealm/Data/RealmBarDataSet.swift
…l/update_upstream * commit '04c5820a6cca34b98cb48b8baab1dd44f44e857d': (61 commits) add switch for clearing `lastHighlighted` in clear() (ChartsOrg#2355) update schemes, move script to file like ChartsRealm use name instead of uuid, add run script for copying missing framework for ChartsTests 1. use xcode 8.3 image 2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI Fix Simple Bar Chart Demo, switch use of x and y values (ChartsOrg#2365) Converted swift 3.0 DBL_MIN leftover Removed leftover script from the combined Realm era Removed leftover scheme v3.0.2 Removed unrequited script gitignore updates Added @discardableResult to silence warnings when it’s safe to ignore result Moved Realm stuff to https://github.com/danielgindi/ChartsRealm Remove line width minimum constraint Updated build-dependencies.sh loosen realm version requirement fix Xcode 8.3 compiler warnings fix ChartsOrg#2222 move default backgroundColor to initialize() as initWithCoder also needs it Updated to use Realm version 2.4.3 Consider _yAxis.isDrawLimitLinesBehindDataEnabled for radar chart ... # Conflicts: # Source/ChartsRealm/Data/RealmBarDataSet.swift
add switch for clearing `lastHighlighted` in clear() fixing a bug: when clearing chart, the 'lastHighlighted' var isn't set to nil. This will cause user to tap twice to highlight the new value, if the new value's index is the same as the old 'lastHighlighted' var's. * adding a switch it controls whether to clear the lasthighlighted value or not
fixing a bug: when clearing chart, the 'lastHighlighted' var isn't set to nil. This will cause user to tap twice to highlight the new value, if the new value's index is the same as the old lastHighlighted's.