-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis config for Xcode 8.3 and fix test failures #2378
Conversation
Rakefile
Outdated
@@ -39,8 +39,8 @@ def devices | |||
{ | |||
iOS: { | |||
sdk: 'iphonesimulator', | |||
device: "id='22FA2149-1241-469C-BF6D-462D3837DB72'", | |||
uuid: '22FA2149-1241-469C-BF6D-462D3837DB72' | |||
device: "34FA4749-C467-4D45-9F8E-E31AEDDC39C2'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id='
is needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@petester42 I guess we need to use Xcode 8.3 image as well? What else to we have to modify? I can do it all in one. Just found what you did for Xcode 8.2: 99e9aa0 But I'm not sure if I just change |
ya. just change the config to be 8.3 |
OK, I have changed to 8.3. Let's see if it can pass |
2. use Apple TV 1080p (10.2) and iPhone 7 (10.3) device id in Travis CI
I tried on my machine with
Any idea? @petester42 I googled but can't find the exact error code solution |
I don't have time right now but I'll look at it maybe tomorrow |
Sure. I also tried to manually run
on my machine, it reports:
Not sure if it's related. I tried to link the framework in ChartTests build phases, but no luck. |
Today, I just tried to manually copy
and just call
It actually succeeded. Still investigating why it did not copy the framework |
c346d52
to
0191044
Compare
…k for ChartsTests
Codecov Report
@@ Coverage Diff @@
## master #2378 +/- ##
=========================================
Coverage ? 19.66%
=========================================
Files ? 112
Lines ? 13710
Branches ? 0
=========================================
Hits ? 2696
Misses ? 11014
Partials ? 0 Continue to review full report at Codecov.
|
Finally all green. @petester42 if the new commits of this PR looks good to you, I will merge it. One shortage is, as We can move $PLATFORM to Rakefile, and later export it again. Sounds not worthy. Or, we build all schemes in the beginning. But I remember you used to build them all, and you just changed to dynamic building, must be some reasons, like Realm took too long? Since we removed Realm, building two schemes should not take much time. Let me know what you think. The run script is referred from Carthage instructions https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos and https://github.com/Carthage/Carthage#adding-frameworks-to-unit-tests-or-a-framework |
update the schemes so test and library are linked (⌘ + U). move coping dependencies to external script like ChartsRealm
update schemes, move script to file like ChartsRealm
for (( n = 0; n < SCRIPT_INPUT_FILE_COUNT; n++ )); do | ||
VAR=SCRIPT_INPUT_FILE_$n | ||
source=${!VAR}.dSYM | ||
dest=${BUILT_PRODUCTS_DIR}/$(basename "$source") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, @petester42 which dSYM is here? and what's for? carthage copy-framework
seems will copy FBSnapshotTestCase.framework.dSYM
under CodeCoverage/Products/Debug-iphonesimulator/
@petester42 sorry to bring this up again, don't know why but I notice travis will compile Charts twice, but on my machine, it seems just once. Do you think we can change |
Update Travis config for Xcode 8.3 and fix test failures
update device id in Travis CI and xcode 8.3 image