Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2099, avoid crash when some chart only allow 1 data set #2500

Merged
merged 1 commit into from
Jun 5, 2017

Conversation

liuxuan30
Copy link
Member

fix #2099, avoid crash when some chart only allow 1 data set but people will set more than that

@codecov-io
Copy link

codecov-io commented Jun 5, 2017

Codecov Report

Merging #2500 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2500   +/-   ##
=======================================
  Coverage   19.65%   19.65%           
=======================================
  Files         112      112           
  Lines       13717    13717           
=======================================
  Hits         2696     2696           
  Misses      11021    11021
Impacted Files Coverage Δ
Source/Charts/Renderers/LegendRenderer.swift 42.46% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1254a87...4a65b41. Read the comment docs.

@liuxuan30 liuxuan30 merged commit 6698fd3 into ChartsOrg:master Jun 5, 2017
@liuxuan30 liuxuan30 deleted the 2099 branch June 5, 2017 02:25
PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
fix ChartsOrg#2099, avoid crash when some chart only allow 1 data set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error when providing multiple data sets in PieChartData
2 participants