Update xcode project for xcode 9 #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
+ Coverage 19.65% 19.73% +0.08%
==========================================
Files 112 113 +1
Lines 13715 13730 +15
==========================================
+ Hits 2695 2710 +15
Misses 11020 11020
Continue to review full report at Codecov.
|
pmairoldi
force-pushed
the
xcode-9
branch
7 times, most recently
from
c2b5d9a
to
1fdc212
Compare
pmairoldi
force-pushed
the
xcode-9
branch
2 times, most recently
from
1025a30
to
8a9dafd
Compare
|
Hi @petester42, this also included #2507, right? |
|
No. Not updated for swift 4. Just making sure project structure is good, code coverage bug is fixed and ci passes. |
|
ah ok, thanks |
PeterSrost
pushed a commit
to sokol8/Charts
that referenced
this pull request
Oct 31, 2018
Update xcode project to support xcode 9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update the Charts project to support Xcode 9 and also fix #2593.