Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated code for set1 in set2 section #2872

Merged
merged 1 commit into from
Oct 17, 2017
Merged

duplicated code for set1 in set2 section #2872

merged 1 commit into from
Oct 17, 2017

Conversation

liuxuan30
Copy link
Member

duplicated code for set1 in set2 section

@codecov-io
Copy link

Codecov Report

Merging #2872 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2872      +/-   ##
=========================================
- Coverage   19.64%   19.6%   -0.05%     
=========================================
  Files         113     113              
  Lines       13792   13841      +49     
=========================================
+ Hits         2709    2713       +4     
- Misses      11083   11128      +45
Impacted Files Coverage Δ
Source/Charts/Highlight/Highlight.swift 0% <0%> (ø) ⬆️
.../Charts/Renderers/Scatter/CrossShapeRenderer.swift 0% <0%> (ø) ⬆️
...urce/Charts/Renderers/Scatter/XShapeRenderer.swift 0% <0%> (ø) ⬆️
...rts/Renderers/Scatter/ChevronUpShapeRenderer.swift 0% <0%> (ø) ⬆️
...Charts/Renderers/Scatter/SquareShapeRenderer.swift 0% <0%> (ø) ⬆️
...s/Renderers/Scatter/ChevronDownShapeRenderer.swift 0% <0%> (ø) ⬆️
...Charts/Renderers/Scatter/CircleShapeRenderer.swift 0% <0%> (ø) ⬆️
Source/Charts/Components/Description.swift 100% <0%> (ø) ⬆️
Source/Charts/Filters/DataApproximator.swift 0% <0%> (ø) ⬆️
...arts/Renderers/Scatter/TriangleShapeRenderer.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8245f32...ad4d942. Read the comment docs.

@liuxuan30 liuxuan30 merged commit 0a63b74 into master Oct 17, 2017
@liuxuan30 liuxuan30 deleted the bubble branch October 17, 2017 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants