Fix turning off drag in X and Y axes separately. #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
- Coverage 19.64% 19.63% -0.01%
==========================================
Files 113 113
Lines 13792 13794 +2
==========================================
Hits 2709 2709
- Misses 11083 11085 +2
Continue to review full report at Codecov.
|
|
@danielgindi seems positive? |
|
@liuxuan30 @danielgindi Any more thoughts on this? |
|
sorry, been busy with work and reviewing those swift refinement. I am positive on your PR, though not tested. I will try later(some fixes shall be included in the next release) |
liuxuan30
approved these changes
Dec 5, 2017
|
Thanks! No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately 3c083f3 broke my change.
The use case when the problem appears is when a chart is embedded in a scroll view. Disabling y axis dragging should enable the scroll view to be used for vertical scrolling with the finger on the chart.
The change in this PR is required for this to work.