Minor changes to Animator

[jjatie]

No description provided.

[codecov-io]

Codecov Report

Merging #3005 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
+ Coverage   19.64%   19.68%   +0.04%     
==========================================
  Files         113      113              
  Lines       13792    13762      -30     
==========================================
  Hits         2709     2709              
+ Misses      11083    11053      -30

Impacted Files	Coverage Δ
Source/Charts/Animation/Animator.swift	1.61% <0%> (+0.31%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1811c7...ee337d7. Read the comment docs.

[pmairoldi]

I think using if let here instead of a one-liner here would be more readable

[jjatie]

I disagree on this one. ?? is a very common operator in Swift (it's all over the stdlib). Would you prefer something like

phaseY = _easingY?(elapsed, duration)
    ?? elapsed / duration

or

phaseY = _easingY?(elapsed, duration) ??
    elapsed / duration

[jjatie]

It's also worth noting that on #2698 there were many cases of this being approved, including this line (thought it was written as phaseY = _easingY?(elapsed, duration) ?? Double(elapsed / duration)

[pmairoldi]

My problem is not with the ?? My problem is with the optional closure. I think It would be clearer to unwrap it first with if let before calling it. It is minor though. It’s up to you.

[jjatie]

I would agree with you in a case like:

let x = myFuncWithNonEscaping? {
     // Logic
} ?? myDefaultValue

But in this case I really think this is okay.

[pmairoldi]

I find it cluttered but it doesn’t really matter.