Fix BalloonMarker's text position calculation, consider insets

[LavareX]

Consider insets, adjust the position of the label in the context of the center.

[codecov-io]

Codecov Report

Merging #3035 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   19.77%   19.77%           
=======================================
  Files         113      113           
  Lines       13663    13663           
=======================================
  Hits         2702     2702           
  Misses      10961    10961

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc40b16...ea00ed0. Read the comment docs.

[liuxuan30]

please give a context what's wrong.

[jjatie]

This seems to be a good change, but as @liuxuan30 said: What is the problem in the current library?

[LavareX]

@liuxuan30 @jjatie Has no effect on the current library, repair logic is not rigorous, ignored the horizontal center.

[liuxuan30]

again, we understand this should not impact the current library, we just need to know what's the change is about. You changed the x position and width to respect inset, we want to know the user case. Did you meet any issue? Or the x direction inset broke something on your side?

I guess when it was implemented, @danielgindi might considered this already, and intended only y direction.

[jjatie]

@yangcaimu This looks like a good change, we just want to document it better so if there is a question or issue in the future, we can quickly understand the justification behind what's there.

[LavareX]

@liuxuan30 @jjatie

Thank you for your patience reply, I'll make it clearer.

At present, the text is centered because the alignment attribute of the _paragraphStyle attribute is assigned to .center. When I change to .left, the text will be completely on the left side of the border, even modify the insets.

If you do not understand, I can provide demo.

[liuxuan30]

ok. So you change to .left, the text aligned on the left is desired result. When you add the inset, what you want to achieve? Adjust the frame x by changing inset?

[LavareX]

Yes, especially in the case of multiple lines, to achieve the effect of left and right edge by changing inset.

[liuxuan30]

@yangcaimu can you post compare images before/after changing the inset?

[thierryH91200]

there is also this solution

RectMarker.swift.zip

[LavareX]

@liuxuan30

Before:
inset = UIEdgeInsets.zero

After:
insets = UIEdgeInsets(top: 8, left: 8, bottom: 20, right: 8)

[jjatie]

@liuxuan30 I like this change.

While it's already currently possible to achieve the same look, I think this way is much more intuitive.

If you're okay with it let's merge.

[liuxuan30]

sure thing. once we know how it looks after fix, it makes sense then.