Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed X-Axis Labels Not Showing (#3154) #3174

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Fixed X-Axis Labels Not Showing (#3154) #3174

merged 1 commit into from
Jan 12, 2018

Conversation

leedsalex
Copy link
Contributor

Fixes #3154

Corrected a mistake in the guard statement.

@leedsalex leedsalex mentioned this pull request Jan 11, 2018
Closed
@jjatie jjatie added this to the 3.1 milestone Jan 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #3174 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3174   +/-   ##
=======================================
  Coverage   22.99%   22.99%           
=======================================
  Files         116      116           
  Lines       15540    15540           
  Branches      272      272           
=======================================
  Hits         3573     3573           
  Misses      11931    11931           
  Partials       36       36
Impacted Files Coverage Δ
...ce/Charts/Formatters/IndexAxisValueFormatter.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c584bf...3b145a4. Read the comment docs.

@jjatie jjatie merged commit 0011c35 into ChartsOrg:master Jan 12, 2018
jjatie added a commit that referenced this pull request Jan 12, 2018
@jjatie
Revert "Fixed X-Axis Labels Not Showing (#3154) (#3174)"
20a04d3 
This reverts commit 0011c35.
@sundeepios
Copy link

Please let me know when this fix will be released..so that i can use this code.

@jjatie
Copy link
Collaborator

jjatie commented Jan 18, 2018

3.1 is scheduled for the end of the month.

philipengberg pushed a commit to tonsser/Charts that referenced this pull request Jan 19, 2018
@leedsalex @philipengberg
Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174)
40e7a04
FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request Jan 20, 2018
@FreddyZeng
Merge branch 'master' of https://github.com/danielgindi/Charts
84123e9 
* 'master' of https://github.com/danielgindi/Charts: (34 commits)
  Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174)
  fix programatical unhighlighting for BarCharView (ChartsOrg#3159)
  Give the users customizable axis label limits (Fixes ChartsOrg#2085) (ChartsOrg#2894)
  bump pod version
  chart views now use open legend renderer property instead of internal one (ChartsOrg#3149)
  Fix axis label disappear when zooming in deep enough (ChartsOrg#3132)
  added DataApproximator+N extension (ChartsOrg#2848)
  Minor cleanup to Highlighter types (ChartsOrg#3003)
  Refactored ChartUtils method into CGPoint extension (ChartsOrg#3087)
  Update ViewPortHandler.swift (ChartsOrg#3143)
  add option to build demo projects unit tests on iOS (ChartsOrg#3121)
  Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994)
  Update 4.0.0 with master (ChartsOrg#3135)
  Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043)
  fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874)
  Makes ChartsDemo compiling again (ChartsOrg#3117)
  Fixed using wrong axis (Issue ChartsOrg#2257)
  Removed methods and properties deprecated in 1.0 (ChartsOrg#2996)
  for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing
  The backing var is not necessary. (ChartsOrg#3000)
  ...

# Conflicts:
#	Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift
#	Source/Charts/Highlight/BarHighlighter.swift
#	Source/Charts/Renderers/BarChartRenderer.swift
@liuxuan30 liuxuan30 added this to Done in 3.1 release Jan 23, 2018
@rl-pavel rl-pavel mentioned this pull request Feb 1, 2018
Closed
@mikeCalvir
Copy link

I still have this problem whichever version I install, I'm hoping v3.1 will fix it - is it likely to be be published soon? (Apologies if this information is publicly visible somewhere here, I couldn't find it on the Releases page).

@jjatie
Copy link
Collaborator

jjatie commented Feb 2, 2018

It will be released very soon!

@ChartsOrg ChartsOrg locked as resolved and limited conversation to collaborators Feb 2, 2018
@liuxuan30
Copy link
Member

liuxuan30 commented Feb 16, 2018 •
edited

@mikeCalvir have you tried latest master branch? or this PR fixed your issue?
@jjatie is busy so I am taking the release job recently after I could clean up my notification inbox to make sure nothing left. So the 3.1 release will be delayed a little. But I'm trying to make it soon.

@ChartsOrg ChartsOrg unlocked this conversation Feb 16, 2018
@mikeCalvir
Copy link

Thanks for the update.
I fixed it by changing to 3.0.4, but also the most critical change it seems was to set wrapEnabled=false on the X Axis, if it it set to true then they never show on any version.

I'll try master again now.

@mikeCalvir
Copy link

They are showing correctly in master

@liuxuan30 liuxuan30 mentioned this pull request Feb 17, 2018
Closed
kzyryanov pushed a commit to fishbrain/Charts that referenced this pull request Feb 20, 2018
@leedsalex
Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174)
458bc71
kalmurzayev pushed a commit to kalmurzayev/Charts that referenced this pull request Feb 26, 2018
@leedsalex @kalmurzayev
Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174)
9a38ce2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjatie jjatie jjatie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.1 release
  
Done
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leedsalex @codecov-io @sundeepios @jjatie @mikeCalvir @liuxuan30