-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed X-Axis Labels Not Showing (#3154) #3174
Fixed X-Axis Labels Not Showing (#3154) #3174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3174 +/- ##
=======================================
Coverage 22.99% 22.99%
=======================================
Files 116 116
Lines 15540 15540
Branches 272 272
=======================================
Hits 3573 3573
Misses 11931 11931
Partials 36 36
Continue to review full report at Codecov.
|
Please let me know when this fix will be released..so that i can use this code. |
3.1 is scheduled for the end of the month. |
* 'master' of https://github.com/danielgindi/Charts: (34 commits) Fixed X-Axis Labels Not Showing (ChartsOrg#3154) (ChartsOrg#3174) fix programatical unhighlighting for BarCharView (ChartsOrg#3159) Give the users customizable axis label limits (Fixes ChartsOrg#2085) (ChartsOrg#2894) bump pod version chart views now use open legend renderer property instead of internal one (ChartsOrg#3149) Fix axis label disappear when zooming in deep enough (ChartsOrg#3132) added DataApproximator+N extension (ChartsOrg#2848) Minor cleanup to Highlighter types (ChartsOrg#3003) Refactored ChartUtils method into CGPoint extension (ChartsOrg#3087) Update ViewPortHandler.swift (ChartsOrg#3143) add option to build demo projects unit tests on iOS (ChartsOrg#3121) Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994) Update 4.0.0 with master (ChartsOrg#3135) Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043) fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874) Makes ChartsDemo compiling again (ChartsOrg#3117) Fixed using wrong axis (Issue ChartsOrg#2257) Removed methods and properties deprecated in 1.0 (ChartsOrg#2996) for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing The backing var is not necessary. (ChartsOrg#3000) ... # Conflicts: # Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift # Source/Charts/Highlight/BarHighlighter.swift # Source/Charts/Renderers/BarChartRenderer.swift
I still have this problem whichever version I install, I'm hoping v3.1 will fix it - is it likely to be be published soon? (Apologies if this information is publicly visible somewhere here, I couldn't find it on the Releases page). |
It will be released very soon! |
@mikeCalvir have you tried latest master branch? or this PR fixed your issue? |
Thanks for the update. I'll try master again now. |
They are showing correctly in master |
Fixes #3154
Corrected a mistake in the guard statement.