Added clamping function for Comparable
#3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3435 +/- ##
==========================================
+ Coverage 29.21% 29.27% +0.06%
==========================================
Files 117 117
Lines 13303 13274 -29
==========================================
Hits 3886 3886
+ Misses 9417 9388 -29
Continue to review full report at Codecov.
|
liuxuan30
reviewed
May 17, 2018
| { | ||
| _lineWidth = newValue | ||
| } | ||
| _lineWidth = newValue.clamped(to: 0.2...12) |
There was a problem hiding this comment.
here 12 is cast to Double by default? is this new swift feature?
There was a problem hiding this comment.
This has been the case since Swift 1
liuxuan30
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding convenience function. There is discussion in the Swift forums about adding this to the language, so we may be able to remove it in the future.