Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken demo link in readme #3440

Merged
merged 3 commits into from
May 3, 2018
Merged

Fix broken demo link in readme #3440

merged 3 commits into from
May 3, 2018

Conversation

robert-cronin
Copy link
Contributor

Issue Link https://github.com/danielgindi/Charts/tree/master/ChartsDemo

The link to ChartsDemo is outdated as there is now separate demos for macOS and iOS, current PR adds separate links to 2 demos for iOS and macOS

added links to 2 demos for iOS and macOS
@codecov-io
Copy link

Codecov Report

Merging #3440 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3440   +/-   ##
=======================================
  Coverage   29.21%   29.21%           
=======================================
  Files         117      117           
  Lines       13303    13303           
=======================================
  Hits         3886     3886           
  Misses       9417     9417

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31d605...d516ee3. Read the comment docs.

@liuxuan30 liuxuan30 merged commit cc73ba7 into ChartsOrg:master May 3, 2018
@liuxuan30
Copy link
Member

Thanks!

FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request May 11, 2018
* 'master' of https://github.com/danielgindi/Charts:
  Fix broken demo link in readme (ChartsOrg#3440)
  update candle chart view options in demo project to toggle showing candle bar (ChartsOrg#3424)
  add seperator set drag for x axis and y axis for Objective-c (ChartsOrg#3421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants