Changes for Swift 4.2, Xcode 10 and iOS 12

[jlcanale]

Issue Link 🔗

Apple renamed keys and functions in Swift 4.2

Goals ⚽

Get a branch started to use these changes during the beta period.

Please merge into a new branch Swift-4.2

[liuxuan30]

based on the experience, we shall hold this until beta 5-6 or GM, and upgrade once and for all.
@jjatie do you think we could finish swift refactor before September?

[jlcanale]

Sounds good, I'll use my fork until then.

[jjatie]

@liuxuan30 I don't think I'll have much time to do that. I can make sure I do the Xcode 10 update and make some changes for Swift 4.2. Some of my bigger changes will likely have to wait until a later time.

[liuxuan30]

@jjatie take your time. I could also take care of Swift 4.2 upgrade. If we cannot make it before Swift 4.2, let's merge into master first and handle our refactoring then.

Some of my bigger changes

Are these bigger changes in target for 4.0 card, or in in progress? There are only two PRs left in in progress: #3164 and #3187.

[jjatie]

@liuxuan30 They aren't on the task board at all. I don't have time to work on them, so there's no point in talking about them now.

@petester42 FYI from Xcode 10 beta 5 notes:

Various CoreGraphics calls have been hardened against continuing with invalid parameters. In iOS 12 beta, these calls may now return NULL or return early. (38344690)

[pmairoldi]

I don’t see where we would be passing invalid parameters.

[Witzeneder]

Is there any update on this matter?

[pmairoldi]

Xcode 10 hasn’t been released yet so no

[kabouzeid]

Xcode 10 GM and Swift 4.2 are out

[jlaws]

As @kabouzeid said, the GM is out and we can start submitting apps using the latest version of XCode. Would be great to get this merged!

[jjatie]

@liuxuan30 @petester42 I have a little time today. Would you like me to get the pod Xcode 10/Swift 4.2 ready? Alternatively, we can do this just for the 4.0.0 branch?

[pmairoldi]

I don’t think 4.0.0 is ready. Do it on master

[dclelland]

@jlcanale I've added a PR to this branch which should fix a few additional Swift 4.2 warnings which popped up in the last few days: jlcanale#1

[pmairoldi]

thanks

[liuxuan30]

cheers guys. My laptop is broken... took sometime to restore everything

[pmairoldi]

I’m finishing things off. Release tonight or tomorrow

[liuxuan30]

sure, thanks a lot

[jlaws]

Works great, thank you!