Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend offset bug for horizontal bar chart (Fixes #3301) #3736

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

SvenMuc
Copy link
Contributor

@SvenMuc SvenMuc commented Nov 7, 2018

Issue Link 🔗

Horizontal Bar Chart legend issue #3301

Goals ⚽

This PR fixes the legend offset issue in case of horizontal bar charts.

Implementation Details 🚧

The guard conditions in the method calculateLegendOffsets in the file HorizontalBarChartView.swift were wrong.

Testing Details 🔍

Tested in own app.

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #3736 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3736   +/-   ##
=======================================
  Coverage   32.67%   32.67%           
=======================================
  Files         114      114           
  Lines       10754    10754           
=======================================
  Hits         3514     3514           
  Misses       7240     7240
Impacted Files Coverage Δ
Source/Charts/Charts/HorizontalBarChartView.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0d809...ee7a218. Read the comment docs.

@liuxuan30
Copy link
Member

Thanks!

@liuxuan30 liuxuan30 merged commit 271606e into ChartsOrg:master Nov 15, 2018
bomjkolyadun added a commit to AnchorFree/iOS-Charts that referenced this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants