fix #3975 (pie chart highlight disabled will lead to empty slice) #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxuan30
added this to Review in progress
in Bugfix and Xcode11 support before 3.3.1 release
|
@jjatie any time recently to take a look at this? |
Bugfix and Xcode11 support before 3.3.1 release
automation
moved this from Review in progress
to Done
Aug 9, 2019
danielgindi
added a commit
that referenced
this pull request
Jan 23, 2020
Fixes #3996, As that PR made normal slices render through highlight code, while disabling shift. So special highlight colors or other styling - would still affect the normal rendering.
Merged
IncredibleStar
added a commit
to IncredibleStar/daniel-charts
that referenced
this pull request
May 26, 2021
Fixes ChartsOrg/Charts#3996, As that PR made normal slices render through highlight code, while disabling shift. So special highlight colors or other styling - would still affect the normal rendering.
rcblue
added a commit
to rcblue/Charts
that referenced
this pull request
Jan 6, 2023
Fixes ChartsOrg/Charts#3996, As that PR made normal slices render through highlight code, while disabling shift. So special highlight colors or other styling - would still affect the normal rendering.
SwiftPolar
pushed a commit
to SwiftPolar/Charts
that referenced
this pull request
Mar 20, 2023
Fixes ChartsOrg#3996, As that PR made normal slices render through highlight code, while disabling shift. So special highlight colors or other styling - would still affect the normal rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we disable highlight for pie chart data set, we still need to render without a shift.
the old code will ignore the highlighted slice in
drawDataSet()byif !chart.needsHighlight(index: j), ifset.highlightEnabled=false, and leave a blank space.