move isDrawCirclesEnabled check further up in code to avoid creating … #4050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessibility labels that will never appear anyway. Reduces CPU significantly for larger datasets.
paulsUsername
approved these changes
Jun 30, 2019
|
This will do wonders. Any idea of when it can be merged and released? |
liuxuan30
approved these changes
Nov 11, 2019
|
sorry guys for the late. It will be merged now. |
water-su
added a commit
to water-su/Charts
that referenced
this pull request
Feb 7, 2020
* origin/master: (256 commits) Add our first super sponsor! Updated test screenshots Add option to draw grid lines in front of data Removed double spacing for labelRotatedHeight Fixes an issue with string comparison in ChartData for finding a dataset by its label (Fixes ChartsOrg#4274) Simplify code Use faster check for line whether it's inside drawing rect Corrected pie `isHighlightEnabled` - render normally when disabled Restored correct velocity sampler Deduplicate BalloonMarker code Unified styling Call chartViewDidEndPanning on when *panning* is ended Propagate file header to newer files Removed redundant minEntries > 0 labelXOffset = 10 is default for radar chart only Update README.md, added link to tutorial about Radar Charts. Changes to fix Catalyst compatibility Allowing overrides for YAxisRenderer.drawYLabels (ChartsOrg#4089) move isDrawCirclesEnabled check further up in code to avoid creating … (ChartsOrg#4050) Platform separation (ChartsOrg#4178) ... # Conflicts: # Source/Charts/Components/AxisBase.swift # Source/Charts/Data/Implementations/Standard/LineRadarChartDataSet.swift # Source/Charts/Highlight/Highlight.swift
SwiftPolar
pushed a commit
to SwiftPolar/Charts
that referenced
this pull request
Mar 20, 2023
ChartsOrg#4050) * move isDrawCirclesEnabled check further up in code to avoid creating accessibility labels that will never appear anyway. Reduces CPU significantly for larger datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…accessibility labels that will never appear anyway. Reduces CPU significantly for larger datasets.
Goals ⚽
Improve draw performance for larger datasets.
Implementation Details 🚧
No need to create accessibility labels for each circle if the circle will never be drawn away.
Testing Details 🔍
After this change drawing and updating 4500 points every 200ms the cpu went from approximately 130% down to about 35%