Start of pan gesture should not be cancelled by no drag #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for the start of a pan, the pan should not be cancelled when the recognizer's translationInView returns 0 in the direction of scrolling. Seems the iPad more easily returns a zero value in the beginning causing the drag to get cancelled immediately even though the actual drag hasn't started because performPanChange() thinks the chart can't be scrolled anymore. So check to see if the drag has vaules that are not actually 0 before calling performPanChange() to prevent immediate pan cancels.
danielgindi
added a commit
that referenced
this pull request
Oct 1, 2015
Start of pan gesture should not be cancelled by no drag
|
Nice catch! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for the start of a pan, the pan should not be cancelled when the recognizer's translationInView returns 0 in the direction of scrolling. Seems the iPad more easily returns a zero value in the beginning causing the drag to get cancelled immediately even though the actual drag hasn't started because performPanChange() thinks the chart can't be scrolled anymore. So check to see if the drag has vaules that are not actually 0 before calling performPanChange() to prevent immediate pan cancels.