address #4033 draw half pie chart more accurate #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxuan30
force-pushed
the
4033
branch
2 times, most recently
from
c0b6d1a
to
571a45d
Compare
jjatie
reviewed
Jan 20, 2020
jjatie
reviewed
Jan 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #4266 +/- ##
==========================================
- Coverage 40.92% 40.82% -0.11%
==========================================
Files 124 124
Lines 9456 9492 +36
==========================================
+ Hits 3870 3875 +5
- Misses 5586 5617 +31
Continue to review full report at Codecov.
|
…aw bigger pie chart.
merge with master and solve conficts
|
@danielgindi have time to take a look? want to be careful |
jjatie
approved these changes
Mar 30, 2020
|
Seems fine to me! |
mosaic-engineering
pushed a commit
to mosaic-io/Charts
that referenced
this pull request
Apr 17, 2020
) * resolve ChartsOrg#4033. when it's half pie and width is larger than height, draw bigger pie chart. * use enum orientation for widthLarger merge with master and solve conficts * fix macOS error, move extension to Platform+CoreGraphics
mosaic-engineering
pushed a commit
to mosaic-io/Charts
that referenced
this pull request
Jun 17, 2020
) * resolve ChartsOrg#4033. when it's half pie and width is larger than height, draw bigger pie chart. * use enum orientation for widthLarger merge with master and solve conficts * fix macOS error, move extension to Platform+CoreGraphics
SwiftPolar
pushed a commit
to SwiftPolar/Charts
that referenced
this pull request
Mar 20, 2023
) * resolve ChartsOrg#4033. when it's half pie and width is larger than height, draw bigger pie chart. * use enum orientation for widthLarger merge with master and solve conficts * fix macOS error, move extension to Platform+CoreGraphics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #4033. when it's half pie and width is larger than height, draw bigger pie chart.
I‘m not in a hurry to merge before it's fully tested and reviewed.
The key idea is to fake the radius and adjust the circle box.
when screen width <= height, it should be the same as a full pie chart, since the radius should be diameter/2 anyway;
but when screen width > height, the radius is min(width, height) to use the maximum space
before:
after:
the portrait portion (width < height) should not be affected.