Restored correct velocity sampler #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjatie Unless you did something there that I'm missing? |
jjatie
reviewed
Jan 23, 2020
| velocitySamples.remove(at: index) | ||
| // while keeping at least one sample | ||
|
|
||
| var i = 0, count = velocitySamples.count |
There was a problem hiding this comment.
I'm not sure what I was doing above.
let index = velocitySamples.firstIndex { currentSample.time - velocitySamples[i].time > 1.0 }
?? velocitySamples.reversed.firstIndex
velocitySamples = velocitySamples.suffix(from: index)
Should achieve the same thing without writing a custom algorithm
There was a problem hiding this comment.
So do you want to add another commit over this PR? Then we will merge it (please test the code first to see that all irrelevant samples are being dropped)
There was a problem hiding this comment.
@jjatie I'm merging this, please add a PR for a Swiftier version when you have the time :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
#3883
Goals ⚽
The sampling algorithm was butchered, so much that old samples do not get dropped (only one of them gets dropped).
The issue is presented when dragging the chart for more than a second, and the releasing. The velocity is incorrect.
Implementation Details 🚧
Restored older algorithm.