round the float value before we cast to Int #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code will cause the visible index incorrect, smaller by 1. Int() simply cuts the fractional part, which usually isn't the desired behaviour ;) Int(round(f)) does the job I met this when that the last label should be year 2015, but it actually shows 2014. It turned out that pt.x is 3.9999999999999987, and Int(pt.x) is 3 More information about the casting can be found here:http://stackoverflow.com/questions/24029917/convert-float-to-int-in-swift
danielgindi
added a commit
that referenced
this pull request
Nov 26, 2015
Fix for rounding error at the edges
|
Thanks :-) |
danielgindi
added a commit
to danielgindi/MPAndroidChart
that referenced
this pull request
Nov 26, 2015
regas99
pushed a commit
to regas99/MPAndroidChart
that referenced
this pull request
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code will cause the visible index incorrect, smaller by 1.
Int() simply cuts the fractional part, which usually isn't the desired behaviour ;) Int(round(f)) does the job
I met this when that the last label should be year 2015, but it actually shows 2014. It turned out that pt.x is 3.9999999999999987, and Int(pt.x) is 3
More information about the casting can be found here:http://stackoverflow.com/questions/24029917/convert-float-to-int-in-swift