LineChartRenderer context bug #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the LineChartRenderers drawLinear method the Context gets saved, but if there is no data to display it never gets restored. This causes other components to disappear. This commit fixes this by saving the context after the check for data to display.
|
This is the correct fix :-) (Also note that there could have been use of |
danielgindi
added a commit
that referenced
this pull request
Feb 10, 2016
Context was saved and sometimes not restored due to `return`
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the LineChartRenderers drawLinear method the Context gets saved before checking for existing data.
This leads to never restoring the context, which causes other chart-components to disappear.
This commit fixes this by saving the context after the check for data.
The bug described above can be seen in the two GIFs below:
Behaviour with bug:
Behaviour with fix:
Relates to #740