Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when using markers with a PieChart #937

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

rofreg
Copy link
Contributor

@rofreg rofreg commented Apr 11, 2016

fa5d01f introduced a crash when using a MarkerView with a PieChartView – because PieChartView no longer has an _xAxis, any attempt to call drawMarkers will crash here. I'm not sure if this is the ideal fix with how you've been refactoring the ChartView classes, but it does restore the ability to use markers with a pie chart.

@danielgindi
Copy link
Collaborator

@PhilJay I'm thinking "Oops!" :-) In the latest axis changes, we didn't notice that a null xAxis might cause trouble. This will happen on Android too.

@danielgindi
Copy link
Collaborator

Thanks @rofreg

@danielgindi danielgindi merged commit 5a0c25f into ChartsOrg:master Apr 12, 2016
@PhilJay
Copy link
Collaborator

PhilJay commented Apr 12, 2016

Yep, it did happen, someone mentioned this already and provided a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants