Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you update to Swift 5.0 ? Or have a schedule? #30

Closed
CaffeCat opened this issue May 16, 2019 · 2 comments
Closed

Would you update to Swift 5.0 ? Or have a schedule? #30

CaffeCat opened this issue May 16, 2019 · 2 comments

Comments

@CaffeCat
Copy link

No description provided.

@pimoon
Copy link

pimoon commented May 20, 2019

Anyone get this thing working with latest realm and swift 5 ?

I can't build because there is errors in code :

1/ Pods/ChartsRealm/ChartsRealm/Classes/Data/RealmBaseDataSet.swift:628:24: Method does not override any method from its superclass

2/ Pods/ChartsRealm/ChartsRealm/Classes/Data/RealmBaseDataSet.swift:630:20: Static member 'copyWithZone' cannot be used on instance of type 'ChartBaseDataSet'

3/ Pods/ChartsRealm/ChartsRealm/Classes/Data/RealmPieDataSet.swift:19:12: Type 'RealmPieDataSet' does not conform to protocol 'IPieChartDataSet'

@liuxuan30
Copy link
Collaborator

sorry. been really busy recently. I don't expect I can do it this month. or at least before the end of May.

There is an PR used to be supporting new swift versions, but not the latest. I pinned the author but no luck yet.
You are welcome to file a PR as well, I'm happy to review and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants