manual "Toggle between light/dark" command is broken

[rafegoldberg]

Love this little extension, but it looks like the Toggle between Light/Dark Themes command broke when I updated to the most recent stable release of VSCode (v1.89.0 on macOS v14.4.1). That said, the actual system-based trigger is still working perfectly when I toggle the color mode at the OS level. It’s just the override command that seems to be broken…

Pretty minor, but I figured it was worth calling out. Anyways, thanks for all your work on this extension; it’s worked perfectly for me to this point! 🤘

[rafegoldberg]

Of note: I found that if I set the window.autoDetectColorScheme setting to false, the manual toggle command starts working again, but it breaks system-level theme tracking… 😭

[danielgjackson]

Hi Rafe, thanks for the bug report. I can confirm I have the same issue. I believe it's related to the changes in VS Code V1.89 -- specifically that, when tracking the system light/dark mode, VS Code now completely ignores any other theme settings.

This seems like an annoying change, particularly for anyone who might want to quickly toggle between light/dark themes for a window (but not necessarily for the whole system). Ideally, they should support the concept of whether the light/dark theme is currently being used, in addition to start and system changes setting it to match the system.

For now, if it doesn't look like something they might fix upstream, I could consider going back to the original method of tracking the system theme (and so turning off VS Code's auto-tracking) -- but I'm afraid that only worked on Windows. I'll have a think about it.

In the meantime, if you are on Windows, you might consider another little utility I wrote: toggle-light-dark -- which changes the whole system mode with one click.