Adding adaptive particle refinement #569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with optional argument
update to exact integration scheme for radiative cooling
…add kappa limitation in multiples
Slow down method and few fixes on the new star formation prescription
…cles onto sinks for ntypes=1
(substepping) reverse 0e0cc6d patch on the particle type sent to ptmass_accrete
|
@becnealon I fixed the merge conflicts here, so this branch is now up-to-date (ie. your branch is only ahead, not behind) As there are quite a lot of changes and so you retain ownership over the relevant lines of code, please can you run the bots on this branch as per instructions below? https://phantomsph.readthedocs.io/en/latest/developer-guide/bots.html |
|
I'm also slightly confused why the merged changes appear like new commits... did history get rewritten here at some point? |
|
Um we both know I'm not clever enough to do that, so don't know but certainly wasn't deliberate.
…________________________________
From: Daniel Price ***@***.***>
Sent: Wednesday, 9 October 2024 11:51 PM
To: danieljprice/phantom ***@***.***>
Cc: Nealon, Rebecca ***@***.***>; Mention ***@***.***>
Subject: Re: [danieljprice/phantom] Adding adaptive particle refinement (PR #569)
I'm also slightly confused why the merged changes appear like new commits... did history get rewritten here at some point?
—
Reply to this email directly, view it on GitHub<#569 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMWRPUCVXY6TMAS4XK2MVWTZ2WXPTAVCNFSM6AAAAABKXPMAHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGU2TQNJWGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
I think it's ok, if I git diff against master then it shows only your changes, so I think it's all good. Please can you run the bots though ? |
|
superseded by #595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
new feature
Description:
Adding adaptive particle refinement as described in Nealon and Price submitted.
Testing:
Regular test suite runs, standalone apr test runs as well.
Did you run the bots? yes/no
Did you update relevant documentation in the docs directory? yes/no