-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable logs totally and fetch currency #13
Comments
Hi @sukiyanen85, It will try to fetch new data even if you have cache enabled if there is no successful requests (cache only starts/counts when you actually have data). Oh and: CC_ENABLE_LOG=false/true is more of a debug log option. It will still log warnings and errors! Sorry for the confusion here, I can add some more information about that. |
Also there should not be anything that triggers a new request, so I assume you have something in your code that expects it to be cached so every time a conversion is attempted it will try to get the EUR rates. PS: I just did a live test trough some feature testing (so not 100% real world practical) and fixer.io seems to work there at least.
|
Hi @danielme85 thank you for taking the time to review. I'm using Laravel Framework 6.18.15. Unfortunately, I had to remove this package, since I'm using rollbar free version, and there's a limit of reported events, due to the package log warnings the package was hitting the account limit :( The package was working fine, but beside I configured 7200 minutes cache, it was called 4211 on the last 20 days. I can confirm that fixer.io was getting the currency correctly. This was the function I was using to get the currency: function toPounds($amount)
{
return Currency::conv('EUR', 'GBP', $amount, 1);
} |
Ah I see, sorry about that. Let me check it out later and see if I find a bug |
Hi,
I'm using rollbar, to track issues\warnings automatically.
My .env configuration:
Beside I have cache timetout set to 7200 minutes the log says that the package is trying to get currency each minute, do you have any idea why this is happening?
My second question is, beside I have LOG set to false. Is still recording warning messages ( which are sent to rollbar )
Any idea how to solve these 2 issues?
The text was updated successfully, but these errors were encountered: